Forecast classes #1115
Draft
Forecast classes #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* define base class * add init test * Fix #1127 --------- Co-authored-by: Valentin Gebhart <valentin.gebhart@usys.ethz.ch> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* Add ImpactForecast * Add unit tests
* Create hazardForecast base class * Update datetime to timedelta for lead_time * Add tests --------- Co-authored-by: luseverin <luca.severino@usys.ethz.ch> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* change leadtime to timedelta * adapt impactforecast docstrings and tests * Remove stray comment --------- Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* Add HazardForecast.select test --------- Co-authored-by: luseverin <luca.severino@usys.ethz.ch> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* Add test for hazardForecast.concat * Skip HazardForecast.concat test --------- Co-authored-by: luseverin <luca.severino@usys.ethz.ch> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* Add test for ImpactForecast.select * minor test modification --------- Co-authored-by: Evelyn Mühlhofer <evelyn.muehlhofer@meteoswiss.ch>
* Add test stub for ImpactForecast.concat * Use correct command for skipping a test * Fix merge issue
* Add data shape check for HazardForecast, ImpactForecast
Adapt Hazard from_hdf5 and write_hdf5 to forecast attributes
* Add extended select impact forecast test * Add extended hazard forecast test --------- Co-authored-by: Chahan Kropf <chahan.kropf@posteo.com> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* Return impactForecast object in _return_impact * Return impactForecast object in _return_empty * Add full impactcalc test for impactForecast * Raise value error when computing impact with impact forecast without saving impact matrix * Cosmetics: Improve error message, move test to own class * Write nans for eai_exp and aai_agg when forecast is used --------- Co-authored-by: luseverin <luca.severino@usys.ethz.ch> Co-authored-by: Chahan Kropf <chahan.kropf@posteo.com> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* add idx boolean selection for member and leadtime * Add test for weird data types --------- Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* Add ImpactForecast.select --------- Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* add HazardForecast.select and extent test --------- Co-authored-by: Eliane Kobler <ekobler@student.ethz.ch> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
peanutfun
force-pushed
the
forecast-class
branch
from
85b92ef to
302be63
Compare
Add min/mean/max methods --------- Co-authored-by: luseverin <luca.severino@usys.ethz.ch> Co-authored-by: Chahan Kropf <chahan.kropf@posteo.com> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* implement changes in Impact IO and ImpactForecast IO * Update tests * Fix small issue when reading H5 for ImpactForecast --------- Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
* Add quantile and median for hazard and impact forecast * Review --------- Co-authored-by: luseverin <luca.severino@usys.ethz.ch> Co-authored-by: Chahan Kropf <chahan.kropf@posteo.com> Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR fixes #
PR Author Checklist
develop)PR Reviewer Checklist